This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Move Lisk-specific transaction types to application-level - Closes #2780 #3498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Lisk Core was using its specific transaction types from Lisk Elements and it should be defined in the application level.
How did I fix it?
I've copied Dapp Transaction, InTransfer Transaction and OutTransfer Transaction into Lisk Core and removed InTransfer/OutTransfer from
elements/lisk-transactions/src/index.ts
DappTransaction is still exposed to keep compatibility in Lisk Elements.
InTransfer/OutTransfer implementation was not removed from Lisk Elements because it's used in
elements/lisk-transactions/src/utils/get_transaction_bytes.ts
How to test it?
Run test suite
Review checklist