Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move Lisk-specific transaction types to application-level - Closes #2780 #3498

Merged
merged 7 commits into from
May 6, 2019

Conversation

lsilvs
Copy link
Contributor

@lsilvs lsilvs commented May 3, 2019

What was the problem?

Lisk Core was using its specific transaction types from Lisk Elements and it should be defined in the application level.

How did I fix it?

I've copied Dapp Transaction, InTransfer Transaction and OutTransfer Transaction into Lisk Core and removed InTransfer/OutTransfer from elements/lisk-transactions/src/index.ts

DappTransaction is still exposed to keep compatibility in Lisk Elements.
InTransfer/OutTransfer implementation was not removed from Lisk Elements because it's used in elements/lisk-transactions/src/utils/get_transaction_bytes.ts

How to test it?

Run test suite

Review checklist

@lsilvs lsilvs force-pushed the 2780-move-lisk-transactions-from-elements branch from ad4283f to 69c12e4 Compare May 3, 2019 14:33
@lsilvs lsilvs force-pushed the 2780-move-lisk-transactions-from-elements branch from 69c12e4 to 4937988 Compare May 3, 2019 15:04
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like something wrong with prettier setting in lisk folder, but let's fix it in lisk-core setting

@pablitovicente pablitovicente self-requested a review May 6, 2019 08:08
@shuse2 shuse2 merged commit f38d4fc into release/2.0.0 May 6, 2019
@shuse2 shuse2 deleted the 2780-move-lisk-transactions-from-elements branch May 6, 2019 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants