Transactions not being instantiated on block receive - Closes #3535 #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing custom configuration while executing an application sandbox in a testing environment requires merging it with the default one. This merge was being performed using `Object.assign` which only performs a shallow merge. Using `lodash`s `.merge` method, deep merge is achieved
This test checks if a node is successfully rejecting transactions that are not allowed in a given context by simu lating a peer sending transactions to the node and then asserting that the transaction is not present in the transaction pool.
This test checks if a node is successfully accepting transactions that are allowed in a given context by simu lating a peer sending transactions to the node and then asserting that the transaction is present in the transaction pool.
2snEM6
force-pushed
the
3535-Transactions_not_being_instantiated_on_block_receive
branch
from
4ca2520
to
43529bc
Compare
shuse2
requested changes
May 7, 2019
2snEM6
force-pushed
the
3535-Transactions_not_being_instantiated_on_block_receive
branch
from
43529bc
to
08bc277
Compare
lsilvs
approved these changes
May 7, 2019
shuse2
approved these changes
May 7, 2019
SargeKhan
approved these changes
May 8, 2019
shuse2
deleted the
3535-Transactions_not_being_instantiated_on_block_receive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Transactions were not being instantiated correctly when receiving a block from another peer causing the block to be rejected.
How did I fix it?
toJSONin its class implementation before being broadcastedHow to test it?
Run matcher integration tests
npx mocha framework/test/mocha/integration/matcher.jsReview checklist