Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirmed transaction count not returned when cache is disabled - Close #3618 #3619

Conversation

pablitovicente
Copy link
Contributor

What was the problem?

Confirmed count not being shown when cache disabled

How did I fix it?

By returning dbCount value when cache is disabled

How to test it?

  • Disable cache in the config
  • Send some transactions and wait for confirmation
  • GET api/node/status data.transactions.confirmed should show confirmed count

Review checklist

@pablitovicente pablitovicente self-assigned this May 14, 2019
@shuse2 shuse2 requested review from 4miners and removed request for shuse2 May 14, 2019 16:04
@shuse2 shuse2 merged commit 735b92d into release/2.0.0 May 14, 2019
@shuse2 shuse2 deleted the 3618-confirmed-transaction-count-not-returned-when-cache-is-disabled branch May 14, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants