New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asset field in BaseTransaction - Closes #3697 #3698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the overridden implementation from the default transaction types. The implementation is the same. Setting to in progress
Signed-off-by: Maciej Baj <macie.baj@gmail.com>
Signed-off-by: Maciej Baj <macie.baj@gmail.com>
f9e5505
to
2f4a95a
Compare
Signed-off-by: Maciej Baj <macie.baj@gmail.com>
Signed-off-by: Maciej Baj <macie.baj@gmail.com>
@shuse2 @SargeKhan I would prefer to keep the simplest version accepting the risk of possible confusion in the case of non-deterministic order of keys in assets. The proper research is currently ongoing. I added the relevant |
For 2.1, we will go with this temporal solution, but it should be mentioned in the documentation that we strongly recommend to override this |
What was the problem?
Each time while defining a transaction extending BasicTransaction there is a need for implementing the complex constructor supporting the asset field and assetToJSON function which is the same for all transaction types.
How did I fix it?
asset
field in the constructor of BasicTransactionassetToJSON
method in BasicTransactionHow to test it?
Review checklist