This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update discovery according to LIP protocol - Closes #3649 #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove discovery time and remove the unecessary probing connection
…those which are in the process of connecting
shuse2
suggested changes
Jun 19, 2019
diego-G
approved these changes
Jun 19, 2019
ishantiw
reviewed
Jun 19, 2019
ishantiw
approved these changes
Jun 19, 2019
shuse2
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Discovery was not consistent with P2P LIP.
How did I fix it?
Made discovery consistent with LIP so that it picks up peers as it connects to them and updated tests.
How to test it?
npm run testReview checklist