Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accounts asset data to the API - Closes #3847 #3879

Merged
merged 3 commits into from Jun 28, 2019
Merged

Add Accounts asset data to the API - Closes #3847 #3879

merged 3 commits into from Jun 28, 2019

Conversation

pablitovicente
Copy link
Contributor

What was the problem?

Asset field was not being returned when using http://localhost:4000/api/accounts

How did I fix it?

By using extended option in the call to storage.get and adding the asset property to accountFormater

How to test it?

  • Build should be green
  • GET http://localhost:4000/api/accounts
  • Update an account with JSON for asset and GET http://localhost:4000/api/accounts contents of result for the updated account should match

Review checklist

@pablitovicente pablitovicente self-assigned this Jun 27, 2019
@pablitovicente pablitovicente marked this pull request as ready for review June 27, 2019 12:43
@shuse2 shuse2 merged commit dcfb049 into release/2.1.0 Jun 28, 2019
@shuse2 shuse2 deleted the 3847-add-accounts-asset-data-to-the-api branch June 28, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsilvs lsilvs lsilvs approved these changes

@shuse2 shuse2 shuse2 approved these changes

Assignees

@pablitovicente pablitovicente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pablitovicente @lsilvs @shuse2