Pararellize travis jobs #410
Conversation
| @@ -42,7 +42,7 @@ describe('POST /peer/transactions', function () { | |||
|
|
|||
| postTransaction(transaction, function (err, res) { | |||
| node.expect(res.body).to.have.property('success').to.be.not.ok; | |||
| node.expect(res.body).to.have.property('message').to.equal('Invalid sender public key: b26dd40ba33e4785e49ddc4f106c0493ed00695817235c778f487aea5866400a expected: ce33db918b059a6e99c402963b42cf51c695068007ef01d8c383bb8a41270263'); | |||
| node.expect(res.body).to.have.property('message').to.equal('Failed to verify signature'); | |||
There was a problem hiding this comment.
Why changed expectations here? Did we change response in this case?
There was a problem hiding this comment.
Expectation changed so the tests simply pass now :) The changes in current PR has nothing common with changing the logic of transactions, so I believe that the problem with this test failing occurred before and is connected with #400
There was a problem hiding this comment.
After the talk with Oliver we came to the conclusion, that the result of that transaction insertion is changed because the tests which are not fired now were changing the state of DB table. This is probably true- the commit (1fc0f03) that changed this expectation was probably added after introducing new test in a different test suite, that mutated db state before.
.travis.yml
Outdated
| @@ -1,16 +1,54 @@ | |||
| dist: 'trusty' | |||
| language: node_js | |||
| node_js: | |||
| - '0.12.17' | |||
| - 6 | |||
There was a problem hiding this comment.
Can we be more specific on version number? Production release will be on 6.9.4.
.travis.yml
Outdated
| - node app.js &> .app.log & | ||
| env: | ||
| global: | ||
| - HOST=http://0.0.0.0:4000 |
There was a problem hiding this comment.
This environment variable is needed?
test/api/accounts.js
Outdated
| before(function (done) { | ||
| require('./../common/globalBefore').waitUntilBlockchainReady(done); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Seeing as we execute this before hook for every test file. Please consolidate these before hooks as one within: https://github.com/LiskHQ/lisk/blob/development/test/node.js. This would be better imo.
There was a problem hiding this comment.
Running the blockchain loaded check in https://github.com/LiskHQ/lisk/blob/development/test/node.js will introduce the need of loading it asynchronously. The condition will have to be run every time when requiring the module. After all, I propose to leave the hooks as they are now.
test/common/globalBefore.js
Outdated
| /** | ||
| * @param {string} table | ||
| * @param {Logger} logger | ||
| * @param {Object} db | ||
| * @param {Function} cb | ||
| */ | ||
| function clearDatabaseTable (db, logger, table, cb) { | ||
| function clearDatabaseTable(db, logger, table, cb) { |
There was a problem hiding this comment.
function clearDatabaseTable (db, logger, table, cb) {
test/common/globalBefore.js
Outdated
| db.query('DELETE FROM ' + table).then(function (result) { | ||
| cb(null, result); | ||
| }).catch(function (err) { | ||
| logger.err('Failed to clear database table: ' + table); | ||
| logger.err('unable to delete data from table: ' + table); |
There was a problem hiding this comment.
logger.err('Failed to clear database table: ' + table);
test/common/globalBefore.js
Outdated
| * @param {Number} [retries=10] retries | ||
| * @param {Number} [timeout=200] timeout | ||
| */ | ||
| function waitUntilBlockchainReady(cb, retries, timeout) { |
There was a problem hiding this comment.
function waitUntilBlockchainReady (cb, retries, timeout) {
test/common/globalBefore.js
Outdated
| if (!timeout) { | ||
| timeout = 200; | ||
| } | ||
| (function fetchBlockchainStatus() { |
There was a problem hiding this comment.
(function fetchBlockchainStatus () {
MaciejBaj
force-pushed
the
407-pararell-travis
branch
from
559001f
to
59714a5
Compare
Create a Travis jobs matrix consisting of seperate tests. closes LiskHQ#407
MaciejBaj
force-pushed
the
407-pararell-travis
branch
2 times, most recently
from
f5335d0
to
78504a6
Compare
MaciejBaj
force-pushed
the
407-pararell-travis
branch
from
78504a6
to
9f6ea0d
Compare
karmacoma
added
ready
and removed
type: bug
chore
type: docs
type: improvement
type: test
labels
Create a Travis jobs matrix consisting of seperate tests.
closes #407