Replace rounds.generateDelegateList by dpos.getRoundDelegates - Closes #4152 #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are failing due to #4147 and should be unskiped once fixed
yatki
suggested changes
Aug 27, 2019
| const nextForger = delegateList[(slot + offset) % ACTIVE_DELEGATES]; | ||
| return seriesCb(nextForger); | ||
| }); | ||
| library.modules.dpos.getRoundDelegates(round).then(delegateList => { |
There was a problem hiding this comment.
if it doesn't require a big refactor, maybe we can await here ?
There was a problem hiding this comment.
I would suggest creating a new issue to replace use of callbacks in this file and use async/await consistently.
yatki
approved these changes
Aug 27, 2019
shuse2
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
rounds.generateDelegateListstill being used in the codebaseHow did I solve it?
By replacing every use of
rounds.generateDelegateListbydpos.getRoundDelegates.During the replacement, it was identified an issue with
dpos.getRoundDelegates-> #4147Because of this issue, two tests were skipped and should be unskipped as part of its fix.
How to manually test it?
Green build
Should sync on testnet at least up to height 10000
Review checklist