Protocol-spec votes - Closes #4182 #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablitovicente
changed the title
| } = require('@liskhq/lisk-cryptography'); | ||
|
|
||
| const BaseGenerator = require('../base_generator'); | ||
| const defaultConfig = require('../../config/devnet'); |
There was a problem hiding this comment.
Will we only support devnet config for now? Or make this configurable in the future?
There was a problem hiding this comment.
We need to discuss how much we want this tool to grow and allot time based on that as this issue is only for generating the JSON I'm trying to avoid big involvements in the library itself as that is just a tool and not the objective but I do agree that we might want to check if we want to develop the tools further.
There was a problem hiding this comment.
Agree, thanks! Let's just keep track of these possible improvements.
…viously voted delegate
pablitovicente
force-pushed
the
4182-procol-specs-votes
branch
from
15555ee
to
1ba5395
Compare
pablitovicente
force-pushed
the
4182-procol-specs-votes
branch
from
a733f87
to
0a4d71f
Compare
2snEM6
approved these changes
Sep 9, 2019
shuse2
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Protocol-specs generators for votes did not exist
How did I solve it?
How to manually test it?
Review checklist