This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update chain loader to call action with correct param - Closes #4501 #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2snEM6
suggested changes
Nov 14, 2019
shuse2
force-pushed
the
4501-fix_rpc_call_from_loader
branch
from
aba6161
to
fefecec
Compare
|
@ManuGowda Test are added |
ManuGowda
approved these changes
Nov 14, 2019
2snEM6
approved these changes
Nov 14, 2019
shuse2
force-pushed
the
4501-fix_rpc_call_from_loader
branch
from
f8f0f7d
to
0b84c88
Compare
shuse2
force-pushed
the
4501-fix_rpc_call_from_loader
branch
from
0b84c88
to
aa18580
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
getTransactions was called with invalid params, and causing banning
How did I solve it?
Call with correct parameter.
How to manually test it?
Start 2 nodes and and observe it will not get banned
Review checklist