Fix applying penalty on transaction processing error - Closes #4528 #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2snEM6
suggested changes
Nov 18, 2019
| @@ -922,7 +923,7 @@ describe('Transport', () => { | |||
| ).toHaveBeenCalledTimes(2); | |||
| }); | |||
|
|
|||
| it('should apply penalty when validateTransactions fails', async () => { | |||
| it.only('should apply penalty when validateTransactions fails', async () => { | |||
shuse2
force-pushed
the
4528-fix_processing_transaction_penalty
branch
from
55b2ac5
to
b2c1191
Compare
2snEM6
approved these changes
Nov 18, 2019
ManuGowda
approved these changes
Nov 18, 2019
shuse2
force-pushed
the
4528-fix_processing_transaction_penalty
branch
from
bde5dab
to
86fcf98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
If transaction fails on the processing, it was applying the penalty.
However, transaction processing can fail in various reason.
How did I solve it?
How to manually test it?
Try to send already processed transaction
Review checklist