This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Commander: generate network identifier - Closes #4559 #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Nov 27, 2019
…isk-sdk into 4559-command_network_identifier
fchavant
approved these changes
Nov 27, 2019
shuse2
suggested changes
Nov 27, 2019
shuse2
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
One needs to install the cryptography library to generate the networkIdentifier, ease of use would be commander have the ability to generate the networkIdentifier for a given communityIdentifier and nethash
How did I solve it?
Adding new command
lisk network-identifierHow to manually test it?
Run command
Review checklist