This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Move network to app level #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
3358-move_network_module_to_app_level
branch
from
7fefc31
to
1be645d
Compare
ishantiw
changed the base branch from
feature/move_chain_network
to
development
ishantiw
changed the base branch from
development
to
feature/move_chain_network
shuse2
suggested changes
Jan 24, 2020
ManuGowda
reviewed
Jan 24, 2020
nazarhussain
suggested changes
Jan 27, 2020
nazarhussain
suggested changes
Jan 27, 2020
nazarhussain
approved these changes
Jan 27, 2020
ManuGowda
approved these changes
Jan 27, 2020
shuse2
approved these changes
Jan 27, 2020
…b.com/LiskHQ/lisk-sdk into 3358-move_network_module_to_app_level * '3358-move_network_module_to_app_level' of https://github.com/LiskHQ/lisk-sdk: Update framework/src/controller/channels/base_channel.js
|
Kudos, SonarCloud Quality Gate passed!
|
shuse2
added a commit
that referenced
this pull request
Jan 31, 2020
…level Move network to app level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the network to application level for the reasons explained in #3358
Review checklist