Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event new block and delete block with accounts - Closes #4825 #4830

Merged
merged 7 commits into from Feb 13, 2020
Merged

Emit event new block and delete block with accounts - Closes #4825 #4830

merged 7 commits into from Feb 13, 2020

Conversation

pablitovicente
Copy link
Contributor

What was the problem?

This PR resolves #4825

How was it solved?

  • By not extending eventEmitter and instead creating an instance of it
  • By emitting events in chain.remove() and chain.save()

How was it tested?

Tests

@pablitovicente pablitovicente self-assigned this Feb 13, 2020
@pablitovicente pablitovicente marked this pull request as ready for review February 13, 2020 14:56
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shuse2 shuse2 merged commit 4dfc588 into development Feb 13, 2020
@shuse2 shuse2 deleted the 4825-emit_event_new_block_and_delete_block_with_accounts branch February 13, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@pablitovicente pablitovicente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit event new block and delete block with accounts
3 participants
@pablitovicente @shuse2 @mitsuaki-u