This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Commander transaction:sign does not produce signatures in correct order - Closes #5002 #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablitovicente
force-pushed
the
5002-commander_transaction_sign_does_not_produce_signatures_in_correct_order
branch
from
9544d60
to
a67947c
Compare
shuse2
approved these changes
Mar 18, 2020
ManuGowda
approved these changes
Mar 18, 2020
…not_produce_signatures_in_correct_order
shuse2
deleted the
5002-commander_transaction_sign_does_not_produce_signatures_in_correct_order
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5002
How was it solved?
By sorting keys in
elements/lisk-transactions/src/sign_multi_signature_transaction.tsHow was it tested?
Unit test