Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index file to application and controller - Closes #5494 #5495

Merged
merged 2 commits into from Jul 1, 2020

Conversation

ManuGowda
Copy link
Contributor

What was the problem?

This PR resolves #5494

How was it solved?

  • Added index files

How was it tested?

  • Updated unit tests

@ManuGowda ManuGowda requested a review from ishantiw July 1, 2020 13:29
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 3 different imports from controller, maybe we can export ActionInfoObject and InMemoryChannel as well from the controller/index file?

import { Controller } from '../controller';

import { InMemoryChannel } from '../controller/channels';

import { ActionInfoObject } from '../controller/action';

@ManuGowda ManuGowda requested a review from ishantiw July 1, 2020 14:06
@ManuGowda ManuGowda merged commit 2fdf71b into development Jul 1, 2020
@ManuGowda ManuGowda deleted the 5494-add-index branch July 1, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add index file to application and controller
3 participants