Add http-api for GET api/node/transactions?limit=xxx&offset=yyy - Closes #5253 #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 10, 2020 10:37
shuse2
requested review from
pablitovicente and
ManuGowda
and removed request for
shuse2
pablitovicente
approved these changes
Jul 10, 2020
ManuGowda
reviewed
Jul 10, 2020
framework-plugins/lisk-framework-http-api-plugin/src/controllers/node.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/node.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/node.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-http-api-plugin/src/controllers/node.ts
Outdated
Show resolved
Hide resolved
mitsuaki-u
force-pushed
the
5253_get_node_tx_pool
branch
from
77da298
to
36be984
Compare
ManuGowda
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Endpoint to retrieve transactions in pool from node was needed.
This PR resolves #5253
How was it solved?
How was it tested?
Run
npm run test:functional node.specunderframework-plugins/lisk-framework-http-api-plugin/