Create sequence module - Closes #5606 #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
5606_create_sequence_module
branch
from
a72aefe
to
76f206f
Compare
shuse2
requested changes
Aug 7, 2020
|
|
||
| // Throw error when tx nonce is not equal to account nonce | ||
| if (tx.nonce !== senderAccount.sequence.nonce) { | ||
| throw new SequenceModuleError( |
There was a problem hiding this comment.
it should throw the NonceOutOfRange error to be handled specifically in the transaction pool
framework/test/unit/specs/modules/sequence/sequence_module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/specs/modules/sequence/sequence_module.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
force-pushed
the
5606_create_sequence_module
branch
from
f423351
to
5ed080c
Compare
pablitovicente
approved these changes
Aug 7, 2020
shuse2
requested changes
Aug 7, 2020
|
|
||
| // Throw error when tx nonce is lower than the account nonce | ||
| if (tx.nonce < senderAccount.sequence.nonce) { | ||
| throw new NonceOutOfBoundsError( |
There was a problem hiding this comment.
This error should be different in order to check in transaction pool.
ie) in transaction pool, the lower nonce is rejected immediately, but higher nonce is accepted.
ishantiw
force-pushed
the
5606_create_sequence_module
branch
from
0486599
to
5851531
Compare
- Implement beforeTransactionApply and afterTransactionApply of sequence module - Create SequenceModuleError - Add id in Transaction interface in base_modules to show in the SequenceModuleError
- Add tests related to when nonce is invalid - Add tests related to when nonce is valid
- Pass nonce under sequence prop inside Account type
- Use SequenceAccount type - Account schema default values should have nonce - Throw NonceOutOfBoundsError error - Update unit tests - Use generics for account.set
- Only need to use getOrDefault in transfer asset of recipient
ishantiw
force-pushed
the
5606_create_sequence_module
branch
from
5851531
to
21a1de6
Compare
shuse2
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5606
How was it solved?
Source:
beforeTransactionApplyandafterTransactionApplyofsequencemoduleSequenceModuleErroridinTransactioninterface inbase_modulesto show in theSequenceModuleErrorTests:
nonceis invalidnonceis validHow was it tested?
Run
npm run test test/unit/specs/modules/sequence/sequence_module.spec.tsunder/framework