Plugins data should be associated to the data path of the application - Closes #5598 #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuGowda
force-pushed
the
5598-fix-data-path
branch
2 times, most recently
from
2432711
to
8cfc306
Compare
all the data related to plugin database should be under //data/plugins/ share rootPath info from controller
ManuGowda
force-pushed
the
5598-fix-data-path
branch
from
551c40f
to
b5cfd20
Compare
pablitovicente
approved these changes
Aug 17, 2020
shuse2
requested changes
Aug 17, 2020
framework-plugins/lisk-framework-forger-plugin/src/defaults/default_config.ts
Show resolved
Hide resolved
shuse2
changed the base branch from
feature/on_chain_architecture
to
development
shuse2
reviewed
Aug 17, 2020
shuse2
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5598
How was it solved?
rootPath/plugins/data/.dbHow was it tested?