Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Create a new event VALIDATOR_CHANGED in lisk-chain - Closes #5656 #5674

Merged
merged 5 commits into from
Aug 19, 2020
Merged

Create a new event VALIDATOR_CHANGED in lisk-chain - Closes #5656 #5674

merged 5 commits into from
Aug 19, 2020

Conversation

pablitovicente
Copy link
Contributor

@pablitovicente pablitovicente commented Aug 19, 2020 •
edited
Loading

What was the problem?

This PR resolves #5656

How was it solved?

  • by emitting an event when setValidators() is executed

How was it tested?

  • Unit Test
  • To test manually change the block time to 4 (as you need to wait 103 blocks for this to fire so lowering the time makes it a little shorter wait) add a console log or subscribe to the new event and you should get the date (if you start a clean node k/v store you need to additionally wait 3 full rounds so in total 4 rounds or around 412 blocks)

@pablitovicente pablitovicente self-assigned this Aug 19, 2020
@pablitovicente pablitovicente marked this pull request as ready for review August 19, 2020 12:25
@shuse2 shuse2 requested a review from ManuGowda August 19, 2020 13:07
shuse2
shuse2 suggested changes Aug 19, 2020
View reviewed changes
framework/src/application/node/node.ts Outdated Show resolved Hide resolved
framework/src/application/node/node.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 6390ebc into development Aug 19, 2020
@shuse2 shuse2 deleted the 5656-create_a_new_event_validator_changed_in_lisk-chain branch August 19, 2020 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@pablitovicente pablitovicente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new event VALIDATOR_CHANGED in lisk-chain
3 participants
@pablitovicente @shuse2 @ManuGowda