Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated commander pallets and readme - Closes #5682 #5683

Merged
merged 1 commit into from Aug 20, 2020
Merged

Remove outdated commander pallets and readme - Closes #5682 #5683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 9 additions & 15 deletions commander/README.md
View file
Open in desktop
Expand Up @@ -20,30 +20,24 @@ Upon successful completion, NPM will add the `lisk-commander` executable `lisk`
$ lisk COMMAND
running command...
$ lisk (-v|--version|version)
lisk-commander/2.0.0 darwin-x64 node-v8.12.0
lisk-commander/5.0.0 darwin-x64 node-v12.18.3
$ lisk --help [COMMAND]
A command line interface for Lisk

VERSION
lisk-commander/2.0.0 darwin-x64 node-v8.12.0
lisk-commander/5.0.0 darwin-x64 node-v12.18.3

USAGE
$ lisk [COMMAND]

COMMANDS
account Commands relating to Lisk accounts.
block Commands relating to Lisk blocks.
config Manages Lisk Commander configuration.
core Install and Manages Lisk Core instances.
copyright Displays copyright notice.
delegate Commands relating to Lisk delegates.
help Displays help.
message Commands relating to user messages.
node Commands relating to Lisk node.
passphrase Commands relating to Lisk passphrases.
signature Commands relating to signatures for Lisk transactions from multisignature accounts.
transaction Commands relating to Lisk transactions.
warranty Displays warranty notice.
account Commands relating to Lisk accounts.
copyright Displays copyright notice.
help Displays help.
message Commands relating to user messages.
passphrase Commands relating to Lisk passphrases.
network-identifier Creates network identifier of Lisk network.
warranty Displays warranty notice.
```

### Running Tests
Expand Down
21 changes: 0 additions & 21 deletions commander/package.json
View file
Open in desktop
Expand Up @@ -53,21 +53,9 @@
"account": {
"description": "Commands relating to Lisk accounts."
},
"block": {
"description": "Commands relating to Lisk blocks."
},
"config": {
"description": "Manages Lisk Commander configuration."
},
"copyright": {
"description": "Displays copyright notice."
},
"delegate": {
"description": "Commands relating to Lisk delegates."
},
"node": {
"description": "Commands relating to Lisk node."
},
"help": {
"description": "Displays help."
},
Expand All @@ -77,12 +65,6 @@
"passphrase": {
"description": "Commands relating to Lisk passphrases."
},
"signature": {
"description": "Commands relating to signatures for Lisk transactions from multisignature accounts."
},
"transaction": {
"description": "Commands relating to Lisk transactions."
},
"warranty": {
"description": "Displays warranty notice."
}
Expand All @@ -96,11 +78,8 @@
"/docs"
],
"dependencies": {
"@liskhq/lisk-api-client": "5.0.0-alpha.0",
"@liskhq/lisk-constants": "1.4.0-alpha.0",
"@liskhq/lisk-cryptography": "3.0.0-alpha.0",
"@liskhq/lisk-passphrase": "3.0.1-alpha.0",
"@liskhq/lisk-transactions": "5.0.0-alpha.0",
"@liskhq/lisk-validator": "0.5.0-alpha.0",
"@oclif/command": "1.5.19",
"@oclif/config": "1.14.0",
Expand Down
12 changes: 5 additions & 7 deletions commander/src/base.ts
View file
Open in desktop
Expand Up @@ -14,14 +14,8 @@
*
*/
import { Command, flags as flagParser } from '@oclif/command';

import { defaultLiskPm2Path } from './utils/core/config';
import { handleEPIPE } from './utils/helpers';
import { print, StringMap } from './utils/print';

// Set PM2_HOME to ensure PM2 is isolated from system wide installation
process.env.PM2_HOME = defaultLiskPm2Path;

export const defaultConfigFolder = '.lisk';

const jsonDescription =
Expand Down Expand Up @@ -66,7 +60,11 @@ export default abstract class BaseCommand extends Command {
);
this.printFlags = flags as PrintFlags;

process.stdout.on('error', handleEPIPE);
process.stdout.on('error', (err: { errno: string }): void => {
if (err.errno !== 'EPIPE') {
throw err;
}
});
}

print(result: unknown): void {
Expand Down