Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate without valid hash onion is unable to forge - Closes #5793 #5802

Merged
merged 5 commits into from Sep 14, 2020
Merged

Delegate without valid hash onion is unable to forge - Closes #5793 #5802

merged 5 commits into from Sep 14, 2020

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Sep 11, 2020

What was the problem?

This PR resolves #5793

How was it solved?

  • Expose a function to return expected reward which also take seed reveal in consideration
  • Use expected reward to calculate quarter fee

How was it tested?

  • Add integration test
  • Run a node from scratch and wait for 1 round, and change seed reveal of on one of the delegate, and check if the delegate creates a block with 0 reward and being accepted

@shuse2 shuse2 self-assigned this Sep 11, 2020
@shuse2 shuse2 marked this pull request as ready for review September 14, 2020 09:32
@ManuGowda ManuGowda changed the title Fix bft reward validation to use extected reward than default reward - Closes #5793 Delegate without valid hash onion is unable to forge - Closes #5793 Sep 14, 2020
ManuGowda
ManuGowda approved these changes Sep 14, 2020
View reviewed changes
framework/src/node/forger/forger.ts Outdated Show resolved Hide resolved
framework/src/node/forger/forger.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 4eace4b into release/5.0.0 Sep 14, 2020
@shuse2 shuse2 deleted the 5793-fix_reward_validation branch September 14, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@Incede Incede Incede approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuse2 @ManuGowda @Incede