Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http api block height query error response - Closes #5808 #5820

Merged
merged 2 commits into from Sep 16, 2020
Merged

Fix http api block height query error response - Closes #5808 #5820

merged 2 commits into from Sep 16, 2020

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Sep 16, 2020

What was the problem?

This PR resolves #5808

How was it solved?

  • Add additional check to see the range within uint32

How was it tested?

  • Add functional test
  • Call the endpoint described in the issue

@shuse2 shuse2 self-assigned this Sep 16, 2020
@shuse2 shuse2 changed the title Fix http api log - Closes #5808 Fix http api block height query error response - Closes #5808 Sep 16, 2020
@shuse2 shuse2 merged commit 1edbf22 into release/5.0.0 Sep 16, 2020
@shuse2 shuse2 deleted the 5808-fix_http_api_log branch September 16, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablitovicente pablitovicente pablitovicente approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuse2 @pablitovicente @mitsuaki-u