Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to have headers contradicting check as pure function - Closes #5894 #5897

Merged
merged 2 commits into from Oct 20, 2020
Merged

Update to have headers contradicting check as pure function - Closes #5894 #5897

merged 2 commits into from Oct 20, 2020

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Oct 20, 2020

What was the problem?

This PR resolves #5894

How was it solved?

  • Refactor to have pure function to check contradicting block headers
  • Update to use the pure function in validation and in reportDelegateMisbehavior asset

How was it tested?

  • All test should pass and behavior except error type should remain

@shuse2 shuse2 self-assigned this Oct 20, 2020
@shuse2 shuse2 requested review from ManuGowda, mitsuaki-u and nazarhussain and removed request for ManuGowda October 20, 2020 13:26
@shuse2 shuse2 merged commit 7087478 into development Oct 20, 2020
@shuse2 shuse2 deleted the 5894_refactor_contradiction_check branch October 20, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor BFT to expose a function to check contradicting block header
3 participants
@shuse2 @nazarhussain @mitsuaki-u