Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WSClient connection for APIClient - Closes #5928 #5964

Merged
merged 10 commits into from Nov 12, 2020
Merged

Implement WSClient connection for APIClient - Closes #5928 #5964

merged 10 commits into from Nov 12, 2020

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

This PR resolves #5928

How was it solved?

  • Created a WSClient class with required interfaces

How was it tested?

  • Added unit tests

@nazarhussain nazarhussain self-assigned this Nov 10, 2020
Base automatically changed from 5921-ws-server-rpc-ws to development November 11, 2020 12:40
@nazarhussain nazarhussain marked this pull request as ready for review November 11, 2020 17:51
shuse2
shuse2 requested changes Nov 12, 2020
View reviewed changes
elements/lisk-api-client/src/create_ws_client.ts Outdated Show resolved Hide resolved
elements/lisk-api-client/src/create_ws_client.ts Outdated Show resolved Hide resolved
elements/lisk-api-client/package.json Show resolved Hide resolved
elements/lisk-api-client/src/create_ws_client.ts Outdated Show resolved Hide resolved
elements/lisk-api-client/src/ws_client.ts Outdated Show resolved Hide resolved
elements/lisk-api-client/src/ws_client.ts Outdated Show resolved Hide resolved
shuse2
shuse2 approved these changes Nov 12, 2020
View reviewed changes
elements/lisk-api-client/src/create_clients.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 243f0d9 into development Nov 12, 2020
@shuse2 shuse2 deleted the 5928-ws-client branch November 12, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement WSClient connection for APIClient
3 participants
@nazarhussain @shuse2 @mitsuaki-u