Copiable text component - Closes #6224 #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
6224_copiable_text
branch
from
c1189cd
to
bd6dec5
Compare
shuse2
requested changes
Mar 24, 2021
|
|
||
| interface Props { | ||
| name: string; | ||
| size?: 's' | 'm' | 'l' | 'xl'; |
There was a problem hiding this comment.
these property i think you can export Props from Text and reference rather than redefining
There was a problem hiding this comment.
Yes it should be exported from Text/index.tsx and then union those types here.
framework-plugins/lisk-framework-dashboard-plugin/src/ui/components/CopyText/index.tsx
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-dashboard-plugin/src/ui/components/CopyText/index.tsx
Outdated
Show resolved
Hide resolved
...work-plugins/lisk-framework-dashboard-plugin/src/ui/components/CopyText/CopyText.module.scss
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .clickableRow { | ||
| float: left; |
There was a problem hiding this comment.
when using flex, Text and Icon components don't align side by side and icon goes to the next line
There was a problem hiding this comment.
the flex needs to be added to the container
nazarhussain
suggested changes
Mar 24, 2021
framework-plugins/lisk-framework-dashboard-plugin/src/ui/components/CopyText/index.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| interface Props { | ||
| name: string; | ||
| size?: 's' | 'm' | 'l' | 'xl'; |
There was a problem hiding this comment.
Yes it should be exported from Text/index.tsx and then union those types here.
♻️ Hide copy icon on copied ♻️ Clear timeout
ishantiw
force-pushed
the
6224_copiable_text
branch
from
56d521c
to
77fb864
Compare
ishantiw
force-pushed
the
6224_copiable_text
branch
from
77fb864
to
d1283b2
Compare
nazarhussain
approved these changes
Mar 25, 2021
shuse2
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6224
How was it solved?
How was it tested?
npm run start:web