Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interoperability message bounce - Closes #7027 #7098

Merged
merged 7 commits into from Apr 5, 2022
Merged

Implement interoperability message bounce - Closes #7027 #7098

merged 7 commits into from Apr 5, 2022

Conversation

mitsuaki-u
Copy link
Contributor

@mitsuaki-u mitsuaki-u commented Apr 4, 2022 •
edited

What was the problem?

This PR resolves #7027

How was it solved?

  • Implemented bounce function in mainchain store

How was it tested?

  • Added unit tests

@mitsuaki-u mitsuaki-u self-assigned this Apr 4, 2022
@mitsuaki-u mitsuaki-u linked an issue Apr 4, 2022 that may be closed by this pull request
Implement bounce() function of InteroperabilityStore #7027
Closed
ishantiw
ishantiw reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment

framework/src/modules/interoperability/mainchain/store.ts Outdated Show resolved Hide resolved
@mitsuaki-u mitsuaki-u requested a review from ishantiw April 5, 2022 12:48
ishantiw
ishantiw approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ishantiw ishantiw merged commit 96896a0 into feature/6915-introduce-interoperability-module Apr 5, 2022
@ishantiw ishantiw deleted the 7027_interop_bounce branch April 5, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@Incede Incede Incede approved these changes

Assignees

@mitsuaki-u mitsuaki-u

Labels
None yet
Projects
No open projects
Lisk SDK Version 6.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bounce() function of InteroperabilityStore
3 participants
@mitsuaki-u @ishantiw @Incede