Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap mainchain and sidechain registration command - Closes #7032 #7112

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #7032

How was it solved?

  • Add MainchainRegistrationCommand class
  • Add SidechainRegistrationCommand class
  • Add constants
  • Add schemas

How was it tested?

n/a

@mitsuaki-u mitsuaki-u self-assigned this Apr 13, 2022
@mitsuaki-u mitsuaki-u requested review from Incede and removed request for ishantiw April 14, 2022 07:33
Copy link
Member

@Incede Incede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, requested a small clarification.

framework/src/modules/interoperability/constants.ts Outdated Show resolved Hide resolved
@mitsuaki-u mitsuaki-u merged commit 9ea6e28 into feature/6915-introduce-interoperability-module Apr 14, 2022
@mitsuaki-u mitsuaki-u deleted the 7032_bootstrap_registration branch April 14, 2022 16:00
@milenagojkovic milenagojkovic linked an issue Apr 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bootstrap mainchain/sidechain registration commands
3 participants