Implement sidechain registration verification and execution - Closes #7033 #7116

mitsuaki-u · 2022-04-22T10:34:42Z

What was the problem?

This PR resolves #7033

How was it solved?

🌱 Create base_interoperability_command class
🌱 Add schemas
🌱 Implement computeValidatorsHash
🌱 Verification hook for sidechain registration execution
🌱 Execution hook for sidechain registration execution
🧪 Added unit tests

How was it tested?

Added unit tests

framework/src/modules/interoperability/utils.ts

framework/src/modules/interoperability/mainchain/commands/sidechain_registration.ts

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts

framework/src/modules/interoperability/mainchain/commands/sidechain_registration.ts

shuse2

Only source code is reviewed for now, I will review the test later

framework/src/modules/interoperability/utils.ts

framework/src/modules/interoperability/mainchain/commands/sidechain_registration.ts

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts

Incede

Looks good, added a couple of minor suggestions.

framework/src/modules/interoperability/schema.ts

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts

mitsuaki-u self-assigned this Apr 22, 2022

mitsuaki-u requested review from ishantiw and Incede and removed request for ishantiw and Incede April 22, 2022 10:34

milenagojkovic linked an issue Apr 26, 2022 that may be closed by this pull request

Implement SidechainRegistrationCommand for mainchain interoperability module #7033

Closed

mitsuaki-u added 16 commits April 28, 2022 17:37

Update schema.ts

2a5471a

Update types.ts

8422991

Add name validation util functions

bbc71d0

Implement sidechain registration verification

f134e6e

Create sidechain_registration.spec.ts

5b34a57

Update sidechain_registration.spec.ts

249f429

Update sidechain_registration.spec.ts

7ff95c0

Create base_interoperability_command.ts

583b3c6

Add empty hash constant

85cd7b9

Add schemas

e292336

Add hash hash input type

0f915d8

Implement computeValidatorsHash util

d77acf6

Update types.ts

8b40465

Implement sidechain registration execution

fae0901

Add unit tests for sidechain registration execution

cd9b22d

Update utils.ts

a4aa955

mitsuaki-u force-pushed the 7033_implement_sidechain_reg branch from 9d00363 to a4aa955 Compare April 28, 2022 16:46

mitsuaki-u requested a review from ishantiw April 28, 2022 16:51

Update sidechain_registration.spec.ts

9e9861c

mitsuaki-u changed the title ~~Implement sidechain registration verification - Closes #7033~~ Implement sidechain registration verification and execution - Closes #7033 Apr 28, 2022

mitsuaki-u added 4 commits April 28, 2022 18:55

Update sidechain_registration.ts

0b01d9b

Update sidechain_registration.spec.ts

5c21bb0

Update types.ts

98754f2

Update utils.ts

194dd75

mitsuaki-u added 4 commits April 29, 2022 11:15

Update schema.ts

3a09dbe

Update sidechain_registration.ts

9f6ddc2

Update schema.ts

d58407c

Update sidechain_registration.spec.ts

af36a57

Incede requested changes May 2, 2022

View reviewed changes

ishantiw reviewed May 3, 2022

View reviewed changes

mitsuaki-u added 3 commits May 4, 2022 11:56

Update sidechain_registration.ts

61693c5

Update utils.ts

85769da

Update sidechain_registration.spec.ts

f40eb0c

mitsuaki-u requested review from Incede, shuse2 and ishantiw and removed request for ishantiw May 4, 2022 10:01

shuse2 requested changes May 4, 2022

View reviewed changes

shuse2 reviewed May 4, 2022

View reviewed changes

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts Outdated Show resolved Hide resolved

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts Show resolved Hide resolved

shuse2 reviewed May 4, 2022

View reviewed changes

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts Show resolved Hide resolved

shuse2 mentioned this pull request May 4, 2022

Implement MainchainRegistrationCommand for sidechain interoperability module - Closes #7034 #7147

Merged

mitsuaki-u added 4 commits May 5, 2022 13:46

Update sidechain_registration.ts

78c2c37

Update schema.ts

b2692d6

Update utils.ts

ff8711f

Update sidechain_registration.spec.ts

68cc1f8

mitsuaki-u requested a review from shuse2 May 5, 2022 13:48

shuse2 approved these changes May 6, 2022

View reviewed changes

Incede requested changes May 6, 2022

View reviewed changes

framework/src/modules/interoperability/schema.ts Show resolved Hide resolved

framework/test/unit/modules/interoperability/mainchain/commands/sidechain_registration.spec.ts Show resolved Hide resolved

Address feedback

039bf4e

mitsuaki-u requested a review from Incede May 6, 2022 09:03

Update schema.ts

274302e

Incede approved these changes May 6, 2022

View reviewed changes

mitsuaki-u merged commit 2c4591b into feature/6915-introduce-interoperability-module May 6, 2022

mitsuaki-u deleted the 7033_implement_sidechain_reg branch May 6, 2022 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement sidechain registration verification and execution - Closes #7033 #7116

Implement sidechain registration verification and execution - Closes #7033 #7116

mitsuaki-u commented Apr 22, 2022 •

edited

shuse2 left a comment

Incede left a comment

Implement sidechain registration verification and execution - Closes #7033 #7116

Implement sidechain registration verification and execution - Closes #7033 #7116

Conversation

mitsuaki-u commented Apr 22, 2022 • edited

What was the problem?

How was it solved?

How was it tested?

shuse2 left a comment

Choose a reason for hiding this comment

Incede left a comment

Choose a reason for hiding this comment

mitsuaki-u commented Apr 22, 2022 •

edited