Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement message recovery commands - Closes #7023 #7142

Merged
merged 4 commits into from May 18, 2022
Merged

Implement message recovery commands - Closes #7023 #7142

merged 4 commits into from May 18, 2022

Conversation

mehmetegemen
Copy link
Contributor

@mehmetegemen mehmetegemen commented Apr 27, 2022 •
edited

What was the problem?

This PR resolves #7023

How was it solved?

  • Added mainchain and sidechain message recovery command and related class, interfaces etc.

How was it tested?

  • Unit tests for both recovery commands

@mehmetegemen mehmetegemen self-assigned this Apr 27, 2022
@mehmetegemen mehmetegemen force-pushed the 7023-interop-msg-rec branch 3 times, most recently from cf5ef7e to e8e4f54 Compare April 28, 2022 14:19
@milenagojkovic milenagojkovic linked an issue Apr 29, 2022 that may be closed by this pull request
Implement mainchain Message Recovery Command execution #7023
Closed
ishantiw
ishantiw requested changes May 9, 2022
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🚀 , just a few comments and questions. Also, waiting for sidechain module's unit tests for message recovery execution

framework/src/modules/interoperability/mainchain/commands/message_recovery.ts Outdated Show resolved Hide resolved
framework/src/modules/interoperability/mainchain/commands/message_recovery.ts Show resolved Hide resolved
framework/src/modules/interoperability/schema.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/interoperability/mainchain/commands/message_recovery.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/interoperability/mainchain/commands/message_recovery.spec.ts Outdated Show resolved Hide resolved
@mitsuaki-u mitsuaki-u self-requested a review May 10, 2022 15:34
@mehmetegemen mehmetegemen marked this pull request as ready for review May 12, 2022 07:28
@ishantiw ishantiw self-requested a review May 12, 2022 13:48
ishantiw
ishantiw approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR @mehmetegemen 🎉

mitsuaki-u
mitsuaki-u approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🚀

@Incede Incede self-requested a review May 18, 2022 12:26
@ishantiw ishantiw merged commit ee59db7 into feature/6915-introduce-interoperability-module May 18, 2022
@ishantiw ishantiw deleted the 7023-interop-msg-rec branch May 18, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricott1 ricott1 ricott1 left review comments

@ishantiw ishantiw ishantiw approved these changes

@Incede Incede Incede approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@mehmetegemen mehmetegemen

Labels
None yet
Projects
No open projects
Lisk SDK Version 6.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement mainchain Message Recovery Command execution
5 participants
@mehmetegemen @ishantiw @ricott1 @Incede @mitsuaki-u