Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event endpoints - Closes #7126 #7159

Merged
merged 2 commits into from May 17, 2022

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented May 10, 2022

What was the problem?

This PR resolves #7126

How was it solved?

  • Add new endpoints in node endpoint

How was it tested?

  • Add unit tests

Additional Information

@shuse2 shuse2 self-assigned this May 10, 2022
@shuse2 shuse2 linked an issue May 10, 2022 that may be closed by this pull request
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments

elements/lisk-tree/src/index.ts Show resolved Hide resolved
framework/src/node/endpoint.ts Show resolved Hide resolved
framework/src/node/endpoint.ts Show resolved Hide resolved
framework/test/unit/node/endpoint.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/node/endpoint.spec.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from ishantiw May 12, 2022 11:43
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shuse2 shuse2 force-pushed the 7127-add_event_handling branch 2 times, most recently from 08655e1 to 6f9f980 Compare May 17, 2022 09:20
Base automatically changed from 7127-add_event_handling to feature/6950-introduce-eventlog May 17, 2022 09:58
@shuse2 shuse2 merged commit e0f4590 into feature/6950-introduce-eventlog May 17, 2022
@shuse2 shuse2 deleted the 7126-add_event_endpoints branch May 17, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add chain_getEvents and chain_proveEvents endpoints
3 participants