Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setHashOnionUsage endpoint #8249

Merged
merged 3 commits into from Mar 10, 2023
Merged

Add a setHashOnionUsage endpoint #8249

merged 3 commits into from Mar 10, 2023

Conversation

Incede
Copy link
Member

@Incede Incede commented Mar 9, 2023

What was the problem?

This PR resolves #8122

How was it solved?

Implement endpoint to set hash onion parameters

How was it tested?

Added unit tests

@Incede Incede requested review from shuse2 and mosmartin March 9, 2023 15:13
@Incede Incede self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #8249 (496536d) into development (e35b64d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 496536d differs from pull request most recent head 9637cc5. Consider uploading reports for the commit 9637cc5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8249      +/-   ##
===============================================
+ Coverage        83.05%   83.07%   +0.01%     
===============================================
  Files              589      589              
  Lines            21800    21796       -4     
  Branches          3185     3183       -2     
===============================================
+ Hits             18107    18108       +1     
+ Misses            3693     3688       -5     
Impacted Files Coverage Δ
framework/src/modules/random/endpoint.ts 100.00% <100.00%> (ø)
framework/src/modules/random/schemas.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

framework/src/modules/random/endpoint.ts Outdated Show resolved Hide resolved
@Incede Incede requested a review from shuse2 March 10, 2023 07:10
Copy link
Contributor

@mosmartin mosmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shuse2 shuse2 enabled auto-merge (squash) March 10, 2023 13:01
@shuse2 shuse2 merged commit 84fbbfa into development Mar 10, 2023
8 checks passed
@shuse2 shuse2 deleted the 8122-onion-usage branch March 10, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a setHashOnionUsage endpoint
3 participants