Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate transactions returned #1229

Closed
Tracked by #1399
sameersubudhi opened this issue Aug 23, 2022 · 2 comments
Closed
Tracked by #1399

Duplicate transactions returned #1229

sameersubudhi opened this issue Aug 23, 2022 · 2 comments
Assignees
Milestone

Comments

@sameersubudhi
Copy link
Member

Actual behavior

Repeated transaction in the response even when queried with different offsets.

Eg: Transaction with ID 0557163513927ed2197ba9ddfbea20c39f62709ac49a4850991f0c7dea4d7e57 is present in the response for the following queries.

With offset 0:
https://service.lisk.com/api/v2/transactions?height=19365983&limit=10&offset=0&includePending=false

With offset 10:
https://service.lisk.com/api/v2/transactions?height=19365983&limit=10&offset=10&includePending=false

Expected behavior

The transaction should appear in only one of the responses since the offset in the second query is greater than equal to the limit set in the first query.

Steps to reproduce

  • Query the above endpoints and check the transactions returned

Which version(s) does this affect? (Environment, OS, etc...)

v0.6.4

@sameersubudhi
Copy link
Member Author

Resolved as part of PR #1326.

@sameersubudhi
Copy link
Member Author

Was fixed for 0.7.0 in PR #1326. Re-opening it to fix for 0.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants