Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Core should have better logs in debug level logging for WS connections #1745

Closed
yairlisk opened this issue Mar 16, 2018 · 0 comments
Closed

Core should have better logs in debug level logging for WS connections #1745

yairlisk opened this issue Mar 16, 2018 · 0 comments
Assignees
@jondubois
Labels
type: improvement
Milestone
Version 1.0.0-alp...

Comments

@yairlisk
Copy link

Expected behavior

Lisk core can supply more robust logs for WS in debug mode. Right now we do not know why peers will not connect from the log. When we have better logs, we can find out more issues and defects.
It could be done in:
api/ws/rpc/connect.js

Actual behavior

Logs in trace mode just show that there are no peers connected.

Steps to reproduce

Start a node that cant connect to configured peer

Which version(s) does this affect? (Environment, OS, etc...)

Ubuntu Linux
1.0.0-alpha.0
Devnet
@yairlisk yairlisk added this to the Version 1.0.0 milestone Mar 16, 2018
@jondubois jondubois mentioned this issue Mar 19, 2018
Merged
MaciejBaj added a commit that referenced this issue Mar 19, 2018
@MaciejBaj
Merge pull request #1753 from LiskHQ/1745-better-debug-messages-for-c…
c855765 
…onnection-failures

Log peer WebSocket connection errors in debug mode - Closes #1745
@MaciejBaj MaciejBaj changed the title Core should have better logs in debug level logging for WS connections. Core should have better logs in debug level logging for WS connections Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jondubois jondubois

Labels
type: improvement
Projects
None yet
Milestone
Version 1.0.0-alpha.1
Development

No branches or pull requests
3 participants
@jondubois @MaciejBaj @yairlisk