Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Package Node.js specified in .nvmrc #2572

Closed
fchavant opened this issue Oct 17, 2018 · 0 comments · Fixed by #2575
Closed

Package Node.js specified in .nvmrc #2572

fchavant opened this issue Oct 17, 2018 · 0 comments · Fixed by #2575
Assignees
@fchavant
Milestone
Version 1.4.0

Comments

@fchavant
Copy link
Contributor

It'd be nice to package whichever version of Node.js is specified in the .nvmrc file of the core we're building.
Instead of storing the expected sha256 sum in config.sh we can download SHASUMS256.txt and SHASUMS256.txt.asc (pubkey should be in this repo)
@fchavant fchavant transferred this issue from LiskArchive/lisk-build Nov 23, 2018
@MaciejBaj MaciejBaj added *hard and removed *easy labels Nov 26, 2018
@fchavant fchavant mentioned this issue Nov 26, 2018
Merged
@MaciejBaj MaciejBaj added this to the Version 1.4.0 milestone Nov 30, 2018
MaciejBaj added a commit that referenced this issue Nov 30, 2018
@MaciejBaj
Merge pull request #2575 from LiskHQ/2572-package-nodejs-from-nvmrc
c48e012 
Build: read Node.js version specified in .nvmrc - Closes #2572
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fchavant fchavant

Labels
None yet
Projects
None yet
Milestone
Version 1.4.0
Development

Successfully merging a pull request may close this issue.

Build: read Node.js version specified in .nvmrc - Closes #2572 LiskArchive/lisk-sdk
2 participants
@MaciejBaj @fchavant