New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests randomly fails on Travis #400

Closed
4miners opened this Issue Jan 20, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@4miners
Member

4miners commented Jan 20, 2017

> Path: GET /api/delegates/voters?publicKey=notAPublicKey
> Response: {"success":false,"error":"Object didn't pass validation for format publicKey: notAPublicKey"}
    ✓ using invalid publicKey should fail
	Waiting for block: Height: 87 Second: 1
	Waiting for block: Height: 87 Second: 2
	Waiting for block: Height: 87 Second: 3
	Waiting for block: Height: 87 Second: 4
	Waiting for block: Height: 87 Second: 5
	Waiting for block: Height: 87 Second: 6
	Waiting for block: Height: 87 Second: 7
	Waiting for block: Height: 87 Second: 8
	Waiting for block: Height: 87 Second: 9
	Waiting for block: Height: 87 Second: 10
	Waiting for block: Height: 87 Second: 11
	Waiting for block: Height: 87 Second: 12
	Waiting for block: Height: 87 Second: 13
	Waiting for block: Height: 87 Second: 14
> Path: GET /api/delegates/voters?publicKey=addb0e15a44b0fdc6ff291be28d8c98f5551d0cd9218d749e30ddb87c6e31ca9
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
TypeError: Cannot read property 'body' of undefined
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:341:53)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:615:12)
    at ClientRequest.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:567:10)
    at ClientRequest.emit (events.js:107:17)
    at Socket.socketErrorListener (_http_client.js:271:9)
    at Socket.emit (events.js:107:17)
    at net.js:459:14

npm ERR! Test failed.  See above for more details.
> Response: {"success":false,"error":"Account is already a delegate"}
    ✓ using same account twice should fail (20094ms)
> Path: PUT /api/transactions/
> Response: {"success":true,"transactionId":"335829060208562234"}
	Waiting for block: Height: 76 Second: 1
	Waiting for block: Height: 76 Second: 2
	Waiting for block: Height: 76 Second: 3
	Waiting for block: Height: 76 Second: 4
	Waiting for block: Height: 76 Second: 5
	Waiting for block: Height: 76 Second: 6
	Waiting for block: Height: 76 Second: 7
	Waiting for block: Height: 76 Second: 8
	Waiting for block: Height: 76 Second: 9
	Waiting for block: Height: 76 Second: 10
	Waiting for block: Height: 76 Second: 11
	Waiting for block: Height: 76 Second: 12
	Waiting for block: Height: 76 Second: 13
	Waiting for block: Height: 76 Second: 14
	Waiting for block: Height: 76 Second: 15
	Waiting for block: Height: 76 Second: 16
	Waiting for block: Height: 76 Second: 17
	Waiting for block: Height: 76 Second: 18
> Path: PUT /api/delegates
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
TypeError: Cannot read property 'body' of undefined
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:341:53)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:615:12)
    at ClientRequest.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:567:10)
    at ClientRequest.emit (events.js:107:17)
    at Socket.socketErrorListener (_http_client.js:271:9)
    at Socket.emit (events.js:107:17)
    at net.js:459:14

npm ERR! Test failed.  See above for more details.
> Path: GET /api/accounts?address=4804269168619813632L
> Response: {"success":true,"account":{"address":"4804269168619813632L","unconfirmedBalance":"200000000","balance":"200000000","publicKey":null,"unconfirmedSignature":0,"secondSignature":0,"secondPublicKey":null,"multisignatures":[],"u_multisignatures":[]}}
    ✓ using varying recipientId casing should go to same address (40206ms)
> Path: POST /peer/transactions
> Response: {"success":false,"message":"Missing recipient"}
    ✓ using transaction with undefined recipientId should fail
> Path: POST /peer/transactions
> Response: {"success":false,"error":"API error: Converting circular structure to JSON"}
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
AssertionError: expected { Object (success, error) } to have a property 'message'
    at Assertion.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/chai/lib/chai/core/assertions.js:898:12)
    at Assertion.ctx.(anonymous function) [as property] (/home/travis/build/LiskHQ/lisk/node_modules/chai/lib/chai/utils/addMethod.js:41:25)
    at /home/travis/build/LiskHQ/lisk/test/api/peer.transactions.main.js:167:34
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:342:4)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:631:3)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:795:18
    at IncomingMessage.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:16:7)

npm ERR! Test failed.  See above for more details.

@4miners 4miners added the bug label Jan 20, 2017

@karmacoma karmacoma added this to Ready in Version 0.7.0 Jan 27, 2017

@karmacoma karmacoma added the *easy label Jan 27, 2017

@karmacoma karmacoma removed this from Ready in Version 0.7.0 Mar 2, 2017

@karmacoma karmacoma added this to In Progress in Version 1.0.0 Mar 2, 2017

@karmacoma karmacoma removed this from In Progress in Version 1.0.0 Mar 7, 2017

@karmacoma karmacoma added this to In Progress in Version 0.7.0 Mar 7, 2017

@karmacoma karmacoma closed this in #460 Mar 7, 2017

karmacoma added a commit that referenced this issue Mar 7, 2017

Merge pull request #460 from MaciejBaj/400-tests-stabilization
Fix stability of dapps test, fix waitUntilBlockchainReady function - Closes #400

@karmacoma karmacoma removed this from In Progress in Version 0.7.0 Mar 7, 2017

@karmacoma karmacoma reopened this Mar 9, 2017

@karmacoma karmacoma closed this in f0f7303 Mar 9, 2017

@karmacoma

This comment has been minimized.

Show comment
Hide comment
@karmacoma

karmacoma Mar 9, 2017

Member

Still not fixed.

Member

karmacoma commented Mar 9, 2017

Still not fixed.

@karmacoma karmacoma reopened this Mar 9, 2017

@karmacoma karmacoma added this to In Progress in Version 1.0.0 Mar 9, 2017

MaciejBaj added a commit that referenced this issue Mar 28, 2017

change double withdrawal test expectation
As unable to control when transaction changes state from queued to confirmed, change test expectation so it not includes transaction id.
Adresses #400

MaciejBaj added a commit that referenced this issue Mar 28, 2017

karmacoma added a commit that referenced this issue Mar 28, 2017

Merge pull request #516 from LiskHQ/400-dapps-test-fix
Improving block reward and dapps test stability - Addresses #400
@Isabello

This comment has been minimized.

Show comment
Hide comment
@Isabello

Isabello Apr 10, 2017

Contributor

This is a timing issue in most cases with tx being put into blocks and checked too late. we should put in waits for anything that is written into blocks so there is time to submit it and also check it before the next block is forged.

Contributor

Isabello commented Apr 10, 2017

This is a timing issue in most cases with tx being put into blocks and checked too late. we should put in waits for anything that is written into blocks so there is time to submit it and also check it before the next block is forged.

@karmacoma karmacoma removed this from In Progress in Version 1.0.0 Apr 21, 2017

@karmacoma karmacoma removed the *easy label Apr 21, 2017

@karmacoma

This comment has been minimized.

Show comment
Hide comment
@karmacoma

karmacoma Apr 21, 2017

Member

Closing as we are moving to Jenkins as a continuous integration solution for the Lisk Core.

Member

karmacoma commented Apr 21, 2017

Closing as we are moving to Jenkins as a continuous integration solution for the Lisk Core.

@karmacoma karmacoma closed this Apr 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment