Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests randomly fails on Travis #400

Closed
4miners opened this issue Jan 20, 2017 · 3 comments
Closed

Tests randomly fails on Travis #400

4miners opened this issue Jan 20, 2017 · 3 comments
Assignees

Comments

@4miners
Copy link
Contributor

4miners commented Jan 20, 2017

> Path: GET /api/delegates/voters?publicKey=notAPublicKey
> Response: {"success":false,"error":"Object didn't pass validation for format publicKey: notAPublicKey"}
    ✓ using invalid publicKey should fail
	Waiting for block: Height: 87 Second: 1
	Waiting for block: Height: 87 Second: 2
	Waiting for block: Height: 87 Second: 3
	Waiting for block: Height: 87 Second: 4
	Waiting for block: Height: 87 Second: 5
	Waiting for block: Height: 87 Second: 6
	Waiting for block: Height: 87 Second: 7
	Waiting for block: Height: 87 Second: 8
	Waiting for block: Height: 87 Second: 9
	Waiting for block: Height: 87 Second: 10
	Waiting for block: Height: 87 Second: 11
	Waiting for block: Height: 87 Second: 12
	Waiting for block: Height: 87 Second: 13
	Waiting for block: Height: 87 Second: 14
> Path: GET /api/delegates/voters?publicKey=addb0e15a44b0fdc6ff291be28d8c98f5551d0cd9218d749e30ddb87c6e31ca9
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
TypeError: Cannot read property 'body' of undefined
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:341:53)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:615:12)
    at ClientRequest.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:567:10)
    at ClientRequest.emit (events.js:107:17)
    at Socket.socketErrorListener (_http_client.js:271:9)
    at Socket.emit (events.js:107:17)
    at net.js:459:14

npm ERR! Test failed.  See above for more details.
> Response: {"success":false,"error":"Account is already a delegate"}
    ✓ using same account twice should fail (20094ms)
> Path: PUT /api/transactions/
> Response: {"success":true,"transactionId":"335829060208562234"}
	Waiting for block: Height: 76 Second: 1
	Waiting for block: Height: 76 Second: 2
	Waiting for block: Height: 76 Second: 3
	Waiting for block: Height: 76 Second: 4
	Waiting for block: Height: 76 Second: 5
	Waiting for block: Height: 76 Second: 6
	Waiting for block: Height: 76 Second: 7
	Waiting for block: Height: 76 Second: 8
	Waiting for block: Height: 76 Second: 9
	Waiting for block: Height: 76 Second: 10
	Waiting for block: Height: 76 Second: 11
	Waiting for block: Height: 76 Second: 12
	Waiting for block: Height: 76 Second: 13
	Waiting for block: Height: 76 Second: 14
	Waiting for block: Height: 76 Second: 15
	Waiting for block: Height: 76 Second: 16
	Waiting for block: Height: 76 Second: 17
	Waiting for block: Height: 76 Second: 18
> Path: PUT /api/delegates
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
TypeError: Cannot read property 'body' of undefined
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:341:53)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:615:12)
    at ClientRequest.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:567:10)
    at ClientRequest.emit (events.js:107:17)
    at Socket.socketErrorListener (_http_client.js:271:9)
    at Socket.emit (events.js:107:17)
    at net.js:459:14

npm ERR! Test failed.  See above for more details.
> Path: GET /api/accounts?address=4804269168619813632L
> Response: {"success":true,"account":{"address":"4804269168619813632L","unconfirmedBalance":"200000000","balance":"200000000","publicKey":null,"unconfirmedSignature":0,"secondSignature":0,"secondPublicKey":null,"multisignatures":[],"u_multisignatures":[]}}
    ✓ using varying recipientId casing should go to same address (40206ms)
> Path: POST /peer/transactions
> Response: {"success":false,"message":"Missing recipient"}
    ✓ using transaction with undefined recipientId should fail
> Path: POST /peer/transactions
> Response: {"success":false,"error":"API error: Converting circular structure to JSON"}
/home/travis/build/LiskHQ/lisk/test/lisk-js/node_modules/js-nacl/lib/nacl_factory.js:27
aughtException",(function(ex){if(!(ex instanceof ExitStatus)){throw ex}}));Mod
                                                                    ^
AssertionError: expected { Object (success, error) } to have a property 'message'
    at Assertion.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/chai/lib/chai/core/assertions.js:898:12)
    at Assertion.ctx.(anonymous function) [as property] (/home/travis/build/LiskHQ/lisk/node_modules/chai/lib/chai/utils/addMethod.js:41:25)
    at /home/travis/build/LiskHQ/lisk/test/api/peer.transactions.main.js:167:34
    at Test.<anonymous> (/home/travis/build/LiskHQ/lisk/test/node.js:342:4)
    at Test.assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:161:6)
    at assert (/home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:131:12)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:631:3)
    at /home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/index.js:795:18
    at IncomingMessage.<anonymous> (/home/travis/build/LiskHQ/lisk/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:16:7)

npm ERR! Test failed.  See above for more details.
@karmacoma
Copy link
Member

Still not fixed.

@karmacoma karmacoma reopened this Mar 9, 2017
MaciejBaj added a commit that referenced this issue Mar 28, 2017
As unable to control when transaction changes state from queued to confirmed, change test expectation so it not includes transaction id.
Adresses #400
MaciejBaj added a commit that referenced this issue Mar 28, 2017
karmacoma added a commit that referenced this issue Mar 28, 2017
Improving block reward and dapps test stability - Addresses #400
@Isabello
Copy link
Contributor

This is a timing issue in most cases with tx being put into blocks and checked too late. we should put in waits for anything that is written into blocks so there is time to submit it and also check it before the next block is forged.

@karmacoma karmacoma removed the easy label Apr 21, 2017
@karmacoma
Copy link
Member

Closing as we are moving to Jenkins as a continuous integration solution for the Lisk Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants