This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Sort delegates for nextForgers endpoint - Closes #1811 #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBaj
approved these changes
Apr 3, 2018
4miners
approved these changes
Apr 3, 2018
fmal
reviewed
Apr 3, 2018
| @@ -799,12 +799,13 @@ Delegates.prototype.getForgers = function(query, cb) { | |||
| library.db.delegates | |||
| .getDelegatesByPublicKeys(forgerKeys) | |||
| .then(rows => { | |||
| rows.map(forger => { | |||
| rows.forEach(forger => { | |||
| forger.nextSlot = | |||
| activeDelegates.indexOf(forger.publicKey) + currentSlot + 1; | |||
|
|
|||
| return forger; | |||
There was a problem hiding this comment.
no need to return here, forEach is meant for side effect
This was referenced Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Next forgers were not sorted by their slot number.
How did I fix it?
Sorted the delegates before sending the response.
How to test it?
Call
/api/delegates/forgersendpointReview checklist