This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add tests to check Node & Postgresql versions - Closes #2388 #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatki
force-pushed
the
2388-unit-tests-for-node-postgres
branch
from
5d7f367
to
73d1859
Compare
yatki
changed the title
fchavant
approved these changes
Sep 13, 2018
|
The node version test should pass once #2393 has been merged. |
MaciejBaj
reviewed
Sep 13, 2018
test/integration/versions.js
Outdated
| const queriesHelper = require('../common/integration/sql/queriesHelper.js'); | ||
| const application = require('../common/application.js'); | ||
|
|
||
| describe('versions', () => { |
There was a problem hiding this comment.
Could we name it more specifically - Dependencies versions?
yatki
force-pushed
the
2388-unit-tests-for-node-postgres
branch
from
73d1859
to
9f71676
Compare
yatki
force-pushed
the
2388-unit-tests-for-node-postgres
branch
from
9f71676
to
bb1c9ea
Compare
ManuGowda
approved these changes
Sep 13, 2018
MaciejBaj
changed the title
MaciejBaj
approved these changes
Sep 14, 2018
MaciejBaj
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We didn't have tests to ensure using right node & Postgresql version
How did I fix it?
I added integration tests
Review checklist