This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Refactor eslint-disable comments - Closes #2447 #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatki
changed the title
yatki
force-pushed
the
2447-remove-disabling-eslint-rules
branch
from
0c268e9
to
eb3e0dc
Compare
diego-G
reviewed
Nov 14, 2018
pablitovicente
approved these changes
Nov 14, 2018
diego-G
approved these changes
Nov 14, 2018
MaciejBaj
approved these changes
Nov 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We were using
eslint-disablecomments at the top of some files and were not enabling again which can increase the chance of having inconsistent code style.How did I fix it?
I wrapped the code blocks with eslint-disable comments and enabled the rules at the end of the code block.
How to test it?
Review checklist