Received post block broadcast request in unexpected format - Closes #2453 #2552
Conversation
When PeersUpdateRules.prototype.{insert|remove} is invoked it means the socket has already connected/disconnected hence the connectionsTable should not be reverted in the case slaveToMasterSender.send fails
| @@ -67,7 +67,6 @@ PeersUpdateRules.prototype.insert = function(peer, connectionId, cb) { | |||
| peer, | |||
| err => { | |||
| if (err) { | |||
| connectionsTable.remove(peer.nonce); | |||
There was a problem hiding this comment.
Shouldn't we move also the connectionsTable.add, after the operation succeeds on the master process, to line https://github.com/LiskHQ/lisk/blob/6feb9a42e13884453b4de3fc64760acdf3af7ee5/api/ws/workers/peers_update_rules.js#L80?
There was a problem hiding this comment.
What the master process will do is to perform the outbound connection but the inbound is already done. We should not wait for the outbound connection in order to populate connectionsTable because it is used to add the nonce to new requests and it makes no difference to have the outbound already or not.
| @@ -67,7 +67,6 @@ PeersUpdateRules.prototype.insert = function(peer, connectionId, cb) { | |||
| peer, | |||
| err => { | |||
| if (err) { | |||
| connectionsTable.remove(peer.nonce); | |||
| if (!err.code) { | |||
There was a problem hiding this comment.
Shouldn't we move also the connectionsTable.remove, after the operation succeeds on the master process, to line https://github.com/LiskHQ/lisk/blob/6feb9a42e13884453b4de3fc64760acdf3af7ee5/api/ws/workers/peers_update_rules.js#L99 ?
There was a problem hiding this comment.
Same explanation as above
What was the problem?
Node was receiving
postBlockcall from a peer not listed in theconnectionsTable.How did I fix it?
As the issue is not reproducible I've improved the code by not undoing the
connectionsTableoperation in caseslaveToMasterSender.sendfails.The reason is because when PeersUpdateRules.prototype.{insert|remove} is invoked it means the socket has already connected/disconnected hence the
connectionsTableshould not be reverted even whenslaveToMasterSender.sendfails.How to test it?
Run network tests
Review checklist