This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Apply eslint-rule consistent-return - Related to #1597 #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
nazarhussain
suggested changes
Nov 22, 2018
MaciejBaj
previously approved these changes
Nov 22, 2018
nazarhussain
previously approved these changes
Nov 22, 2018
MaciejBaj
previously approved these changes
Nov 22, 2018
MaciejBaj
previously approved these changes
Nov 23, 2018
nazarhussain
previously approved these changes
Nov 23, 2018
nazarhussain
previously approved these changes
Nov 23, 2018
|
@diego-G please resolve the conflicts: |
ManuGowda
suggested changes
Nov 26, 2018
modules/loader.js
Outdated
| __private.loadSignatures, | ||
| err => { | ||
| if (err) { | ||
| library.logger.log('Signatures loader', err); |
There was a problem hiding this comment.
this should be library.logger.error or library.logger.info instead of log
modules/loader.js
Outdated
| __private.loadTransactions, | ||
| err => { | ||
| if (err) { | ||
| library.logger.log('Unconfirmed transactions loader', err); |
There was a problem hiding this comment.
this should be library.logger.error or library.logger.info instead of log
diego-G
force-pushed
the
1597-apply-eslint-rule-consistent-return
branch
from
90dca36
to
aa1e442
Compare
ManuGowda
approved these changes
Nov 26, 2018
nazarhussain
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review checklist