This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Build: read Node.js version specified in .nvmrc - Closes #2572 #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use and package whichever Node.js version is specified in the .nvmrc file; download/check/unpack Node.js in Makefile.
fchavant
force-pushed
the
2572-package-nodejs-from-nvmrc
branch
from
98d52be
to
8a1fd98
Compare
MaciejBaj
approved these changes
Nov 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The Node.js version to use was contained in both
.nvmrcandbuild/config.shHow did I fix it?
The build process now reads the version of Node.js to use and package from
.nvmrc.How to test it?
Run build, see
build/README.md.Review checklist