Apply eslint-rule no-shadow - Related to #1597

[diego-G]

Review checklist

• The PR is related to Enable pending eslint rules #1597
• All new code is covered with unit tests
• All new code was formatted with Prettier
• Linting passes
• Tests pass
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[ManuGowda]

@diego-G overall the purpose of the PR is great, but in my opinion at some places the naming are not the convincing, I have left few comments and feedback, please feel free to go over it and if there is room for improvement please do them.

[MaciejBaj]

Using underscores in names is also not recommended and conflicting with the other ESLint rule - https://eslint.org/docs/rules/no-underscore-dangle.

[diego-G]

@maciej the rule we apply comes straight from AirBnb repo. My Lint doesn't show any conflicts. Could you point me to the place you refer?
For reference: https://github.com/airbnb/javascript/blob/17e0454672f784772c5f5ab052523a93229d9adf/packages/eslint-config-airbnb-base/rules/style.js#L371

[MaciejBaj]

Please use the meaningful variable names.

[nazarhussain]

If you exclude that controllers/node.js everything else seems pretty good to me.