This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Always pass a callback as the last function parameter - Closes #2449 #2597
Merged
MaciejBaj
merged 6 commits into
development
from
2449-improve-parameters-for-wait_for-util-functions
Dec 6, 2018
Merged
Always pass a callback as the last function parameter - Closes #2449 #2597
MaciejBaj
merged 6 commits into
development
from
2449-improve-parameters-for-wait_for-util-functions
Dec 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBaj
changed the title
Change waitfor functions to expect cb as last parameter - Closes #2449
Always pass a callback as the last function parameter - Closes #2449
Nov 30, 2018
MaciejBaj
suggested changes
Nov 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a lot of (100+) places where callback is being passed not as the last parameter. The pattern I used to find them is: cb,
@MaciejBaj this Issue/PR was originally only for wait_for file. Should this now be implemented application wise? ( Also take into account that your pattern will match |
@pablitovicente ok, let's leave the wait_for only for now. Please solve the conflicts. |
MaciejBaj
approved these changes
Dec 6, 2018
MaciejBaj
deleted the
2449-improve-parameters-for-wait_for-util-functions
branch
December 6, 2018 16:19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Functions from wait_for.js did not followed NodeJS' convention of accepting a callback at last parameter.
How did I fix it?
How to test it?
Review checklist