Always pass a callback as the last function parameter - Closes #2449

[pablitovicente]

What was the problem?

Functions from wait_for.js did not followed NodeJS' convention of accepting a callback at last parameter.

How did I fix it?

• Changed the functions signatures to accept the callback as last parameter
• Updated files, when required, that are using wait_for functions

How to test it?

• build should pass

Review checklist

• The PR resolves Always pass a callback as the last function parameter #2449
• All new code is covered with unit tests
• All new code was formatted with Prettier
• Linting passes
• Tests pass
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[MaciejBaj]

There is still a lot of (100+) places where callback is being passed not as the last parameter. The pattern I used to find them is: cb,

[pablitovicente]

@MaciejBaj this Issue/PR was originally only for wait_for file. Should this now be implemented application wise?

( Also take into account that your pattern will match setImmediate which is correct for it to have the callback as the first parameter if you instead search for , cb, then you get 65 results but the above question about scope change remains regardless of this note)

[MaciejBaj]

@pablitovicente ok, let's leave the wait_for only for now. Please solve the conflicts.