This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Standardise stubbing - Closes #306 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
force-pushed
the
306-standardise_stubbing
branch
from
a79edb5
to
f469234
Compare
Where an existing object is having its methods stubbed, not where a standalone stub is created e.g to pass as an argument to a function.
willclarktech
force-pushed
the
306-standardise_stubbing
branch
from
f469234
to
91a27b4
Compare
toschdev
approved these changes
Nov 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306
Merge #328 firstFrom now on, step definitions should assume that methods are already stubbed, and the actual stubbing should happen in a setup function. The exception is standalone stubs/spies, created directly (i.e.
sandbox.stub()orsandbox.spy(), in order e.g. to be passed as an argument to a function being tested. In such cases there's nothing to stub in the setup phase.