Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing icons #1042

Closed
5 tasks done
DimitriDR opened this issue Jan 7, 2023 · 8 comments
Closed
5 tasks done

[BUG] Missing icons #1042

DimitriDR opened this issue Jan 7, 2023 · 8 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@DimitriDR
Copy link
Contributor

Environment

Self-Hosted (Docker)

System

Docker 20.10.3

Version

2.1.1

Describe the problem

When working on #1041, I found two buttons where the text was weirdly aligned.

image

It's actually because there's an icon in each button, but they don't appear.

<!-- Save and cancel buttons -->
    <div class="action-buttons">
      <Button :click="saveChanges">
        <SaveIcon /> {{ $t('theme-maker.save-button') }}
      </Button>
      <Button :click="resetUnsavedColors">
        <CancelIcon /> {{ $t('theme-maker.cancel-button') }}
      </Button>
    </div>

^ In: src/components/Settings, lines 49 to 57.

Additional info

No response

Please tick the boxes

@DimitriDR DimitriDR added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jan 7, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Feb 7, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 7, 2023
@DimitriDR
Copy link
Contributor Author

Still relevant.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Feb 7, 2023
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Mar 10, 2023
@DimitriDR
Copy link
Contributor Author

Still relevant.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Mar 10, 2023
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Apr 10, 2023
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Apr 15, 2023
@Lissy93 Lissy93 reopened this Dec 31, 2023
@Lissy93
Copy link
Owner

Lissy93 commented Dec 31, 2023

Hmm, yes - looks like the Save and Cancel buttons aren't loading because font-awesome not enabled.
I'll push a fix out, but in the meantime setting enableFontAwesome to true (under appConfig) should fix this, re, here.

@CrazyWolf13
Copy link
Collaborator

@Lissy93 Guess this could be closed, as a fix was pushed and solution provided.
😊

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 1, 2024
@Lissy93 Lissy93 closed this as completed Feb 11, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants