Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] title in browser tab doesnt changes #645

Closed
nikiforovst opened this issue May 10, 2022 · 7 comments
Closed

[BUG] title in browser tab doesnt changes #645

nikiforovst opened this issue May 10, 2022 · 7 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@nikiforovst
Copy link

nikiforovst commented May 10, 2022

Environment

Self-Hosted (Docker)

Version

2.0.8

Describe the problem

pageinfo.title does not changes title in browser tab.
This was tested on multiple systems (windows 10/ centOS 7) and different browsers (chrome/edge/IE).

Steps to reproduce:

  1. Deploy new compose stack in docker as described in documentation (https://dashy.to/docs/deployment#using-docker-compose)
  2. Change title (doesn matter via GUI of config files) - same behaviour - title of browser tab does not changes.

Additional info

Screenshot clrd

Please tick the boxes

Welcome to Dashy, so glad you're here :) Deployment is super easy, and there are several methods available depending on what type of system you're using. If you're self-hosting, then deploying with Docker (or similar container engine) is the recommended approach.
@nikiforovst nikiforovst added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label May 10, 2022
@Lissy93 Lissy93 reopened this May 10, 2022
Repository owner deleted a comment from liss-bot May 10, 2022
@nikiforovst nikiforovst changed the title [BUG] <title> [BUG] title in browser tab doesnt changes May 10, 2022
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in 2.0.9 ✨

If you haven't done so already, please update your instance to 2.0.9 or later. See 2.0.9 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

@Techtony96
Copy link

Techtony96 commented Apr 3, 2023

I am having this exact issue on 2.1.1, using docker to deploy. Tested in multiple browsers.

image

latest: Pulling from lissy93/dashy
Digest: sha256:0bd8549e1f7157a14348a3de81d7f86babbf18583eada052af4b59e37c9e2764
Status: Image is up to date for lissy93/dashy:latest
docker.io/lissy93/dashy:latest
root@docker:~/docker/hub# docker logs -f hub 
yarn run v1.22.15
$ node server
Checking config file against schema...
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  Warning: 1 issue found in config file  
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
1. /pageInfo/navLinks must be array 
SSL Not Enabled: Public key not present

 ██████╗  █████╗ ███████╗██╗  ██╗██╗   ██╗
 ██╔══██╗██╔══██╗██╔════╝██║  ██║╚██╗ ██╔╝
 ██║  ██║███████║███████╗███████║ ╚████╔╝
 ██║  ██║██╔══██║╚════██║██╔══██║  ╚██╔╝
 ██████╔╝██║  ██║███████║██║  ██║   ██║
 ╚═════╝ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═╝   ╚═╝

*******************************************************************************************
Welcome to Dashy! 🚀
Your new dashboard is now up and running with Docker
*******************************************************************************************

Using Dashy V-2.1.1. Update Check Complete
✅ Dashy is Up-to-Date

@miguelgrc
Copy link

Same issue here, also running 2.1.1

1 similar comment
@davidfuzju
Copy link

Same issue here, also running 2.1.1

@mkhinda29
Copy link

Same issue here on 2.1.1.
I was able to get it to work by changing my docker startup command to be
command: ["yarn", "build-and-start"] as per the guidance in the developing section.

This recompiles the assets and the title lines up with what I expect.

The downside is that the yarn build adds 30+ seconds to the boot time of the dashboard.

@gdeans
Copy link

gdeans commented Jan 17, 2024

I'll try this when I get a chance. Do you need to run that command one time and then revert back?

@mkhinda29
Copy link

I'll try this when I get a chance. Do you need to run that command one time and then revert back?

If you can find a way to retain the filesystem that the dashy service is using then in theory that might work.
I am using docker compose and if I revert the startup command, it will re-create the container and it will drops the filesystem that had the build changes.

You could add a entrypoint script and manage it that way? It wasn't a big enough deal to spend any more time on ¯_(ツ)_/¯

Here is what the compose service looks like when it works if that helps. For now, I've just commented out the command: ["yarn", "build-and-start"] line and moved on.

  dashboard:
    container_name: dashboard
    image: lissy93/dashy
    command: ["yarn",  "build-and-start"]
    volumes:
      - ./conf/dashy/my-config.yml:/app/public/conf.yml
      - ./conf/dashy/item-icons:/app/public/item-icons
    ports:
      - 4000:80
    environment:
      - NODE_ENV=production
    restart: unless-stopped
    healthcheck:
      test: ['CMD', 'node', '/app/services/healthcheck']
      interval: 1m30s
      timeout: 10s
      retries: 3
      start_period: 40s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
None yet
Development

No branches or pull requests

8 participants