Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sports Widget doesn’t display Premier League image correctly #654

Closed
4 tasks done
Bod1985 opened this issue May 14, 2022 · 4 comments
Closed
4 tasks done
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.9

Comments

@Bod1985
Copy link

Bod1985 commented May 14, 2022

Environment

Self-Hosted (Docker)

Version

2.0.8

Describe the problem

In Safari on iOS (iPad and iPhone), the image for Premier League games is the wrong size meaning only the background colour shows.

The image is definitely loading as it can be long pressed and saved to photos.

Please see the following image:

IMG_0306

Additional info

No response

Please tick the boxes

@Bod1985 Bod1985 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label May 14, 2022
@Lissy93
Copy link
Owner

Lissy93 commented May 14, 2022

Hmm, looks like it's going to be this class in SportsScores.vue:

img.match-thumbnail {
width: 100%;
height: fit-content;
margin-top: -13%;
}

But I do not have any iOS/ Apple devices to test this out (I'm too poor lol), so would anyone else be able to submit a PR for this one?

@Bod1985
Copy link
Author

Bod1985 commented May 14, 2022

Hmm, looks like it's going to be this class in SportsScores.vue:

img.match-thumbnail {
width: 100%;
height: fit-content;
margin-top: -13%;
}

But I do not have any iOS/ Apple devices to test this out (I'm too poor lol), so would anyone else be able to submit a PR for this one?

I will have a go at some point when I’m back at my desk.

I wonder also if it would be possible to have an option to show/hide the image? I quite like the minimalist look with just a score line

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 14, 2022
@Lissy93
Copy link
Owner

Lissy93 commented May 14, 2022

I can easily add an option to hide the image, that's a good idea - I'll do that now...

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 14, 2022
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in 2.0.9 ✨

If you haven't done so already, please update your instance to 2.0.9 or later. See 2.0.9 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.9
Projects
None yet
Development

No branches or pull requests

3 participants