Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Image widget update functionality #1008

Merged
merged 4 commits into from
Dec 10, 2022

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Dec 10, 2022

Medium Lissy93 /FEATURE/static-widget-update → Lissy93/dashy Commits: 4 | Files Changed: 3 | Additions: 46 Label

Category: Feature

Overview

  • Adds update functionality to Image widget
    • Now the updateInterval option works, for automatic periodic updates, and the "Refresh" button also works
  • Improves update functionality for iframe widget too
  • Also adds an option to specify image dimensions for Image widget

Issue Number #992

New Vars N/A

Screenshot
Here's an example, for demonstration purposes, we're using imagePath: https://loremflickr.com/640/360 to show a new cat pic on each update 😺

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Dec 10, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 94ce53f
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6394d4c635051d00093b1fc3
😎 Deploy Preview https://deploy-preview-1008--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Dec 10, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 5711790 into master Dec 10, 2022
@Lissy93 Lissy93 deleted the FEATURE/static-widget-update branch December 10, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant