Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Serve index.html as fallback to fix #1067 #1068

Merged

Conversation

itsmejoeeey
Copy link
Contributor

@itsmejoeeey itsmejoeeey commented Jan 16, 2023

itsmejoeeey Quick itsmejoeeey /BUG/1067_Server-fallback-serve-index → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 2 Label

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Bugfix

Overview

Briefly outline your new changes...

Appended a catch-all 'route' to the end of the express app (that serves dist/index.html). This fixes the issue and allows navigating directly to a route, such as <SERVER_URL>/workspace/.

Issue Number (if applicable) #1067

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 12eadcc
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63c5449e0ccba000094e0ab3
😎 Deploy Preview https://deploy-preview-1068--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 16, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@liss-bot
Copy link
Collaborator

This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 16, 2023
@itsmejoeeey
Copy link
Contributor Author

itsmejoeeey commented Feb 16, 2023

The PR is still relevant and awaiting review.

@Lissy93 Please let me know if this PR requires any changes.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 16, 2023
@Lissy93
Copy link
Owner

Lissy93 commented Feb 19, 2023

Sorry for the delay, this totally slipped my mind

@Lissy93 Lissy93 merged commit b18895b into Lissy93:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants